Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Automatically create a branch if it does not exist #3605

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Nov 25, 2024

Implements #3584

  • Running etlr github/co2_data --export creates a branch with the same name as working ETL branch and commits updated files there.
  • If the branch exists, push a new commit. (@pabloarosado's suggestion was to fail, but I think it's pretty safe to add a commit given that we don't overwrite existing ones and we create a PR at the end)
  • Prefer GITHUB_TOKEN over OWIDBOT_ACCESS_TOKEN (in the future, we should clean it up and use only a single env)
  • Show a link to create a PR from our branch

@owidbot
Copy link
Contributor

owidbot commented Nov 25, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-export-create-branch

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-25 09:48:18 UTC
Execution time: 16.78 seconds

Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will be helpful on the next update!

@Marigold Marigold marked this pull request as ready for review November 28, 2024 20:02
@Marigold Marigold merged commit 8284c34 into master Nov 28, 2024
9 checks passed
@Marigold Marigold deleted the export-create-branch branch November 28, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants