-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📊 war: add conflict participants #1881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still not sure how to review this by looking at the charts. They seem fine, but I wonder about the differences between the different sources for the number of countries in conflict. I created this chart and I don't know why COW or Mars are far from the other metrics
Thanks, @paarriagadap. Sorry if this was confusing. Just in case something odd strikes at first sight is enough. Feel free to review the code, but I reckon this project is slowly becoming a monster code-wise. On
It mostly comes from the fact that the different sources have different may have different definitions for conflicts,; some include different types of conflicts, and others don't etc. Thanks for creating the chart, it is actually very insightful on these discrepancies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it's working fine. One thing I don't like for maps is the line chart in the tooltip for a binary indicator, but I guess that's the prize to pay to have a line chart tab as well.
Adding conflict participants by year and conflict type. This means creating a new table with three keys: country, year and conflict_type and one column indicating if that country was involved in a conflict for that year.
How to review
I'd say that just checking some of the charts below is enough. Maybe some details in the metadata files. But no need to go very much in detail in the code as there are different files being modified.
Countries in conflict
Indicator stating if a country was in conflict for a year and conflict type (binary indicator)
Brecke(won't do)Timeline
Good to know
The same country can be involved in multiple conflict types. For instance, suppose a country is involved in an interstate conflict and an intrastate one. While this adds 1 to categories (
number of countries in intrastate conflicts
andnumber of countries in interstate conflicts
), it also adds just 1 (and not 2) tonumber of countries in state-based conflicts
(bc it is the same country).