Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add World excluding China and India data for World Bank PIP #2528

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

paarriagadap
Copy link
Contributor

@owidbot
Copy link
Contributor

owidbot commented Apr 16, 2024

Staging server:
etl diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile are not included

Edited: 2024-04-16 22:00:40 UTC

@paarriagadap paarriagadap force-pushed the add-world-excluding-china-pip branch from 904b23e to f3cc587 Compare April 17, 2024 00:42
@paarriagadap
Copy link
Contributor Author

paarriagadap commented Apr 17, 2024

Hi @Marigold! I am not sure why the staging server is not updating my latest changes. I see all the checks green, though I see Datadiff failed (with a body is too long error?). Could it be related to this? The branch is rebased.

I can't see the entity World (excluding India) in this chart: http://staging-site-add-world-excluding-china-pip/admin/charts/5111/edit. I will check back tomorrow.

@Marigold
Copy link
Collaborator

Thanks for reporting the datadiff issue, I'm looking into it. (By the way, checks should be green even if Datadiff is failing, so this is expected)

Missing entity World (excluding India) was a bug, sorry for that 😢. I fixed it on master, and the entity is there now (you can rebase on top of master just to be sure).

@paarriagadap paarriagadap force-pushed the add-world-excluding-china-pip branch from f3cc587 to 6ba470d Compare April 17, 2024 14:09
@paarriagadap
Copy link
Contributor Author

Thank you @Marigold! Now I can see it. I will merge, but with the rebase I see that the Refresh grapher job fails now. Here.

@paarriagadap paarriagadap merged commit d530598 into master Apr 17, 2024
8 of 9 checks passed
@paarriagadap paarriagadap deleted the add-world-excluding-china-pip branch April 17, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants