Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📊 Intact Forest Landscapes #2625

Merged
merged 4 commits into from
May 14, 2024
Merged

📊 Intact Forest Landscapes #2625

merged 4 commits into from
May 14, 2024

Conversation

spoonerf
Copy link
Contributor

@spoonerf spoonerf commented May 8, 2024

Hey @pabloarosado!

For this PR I am not sure how to handle the source. The author (Potapov) asked that we cite it as Potapov et al. (2017) and reference the paper that sets out the dataset. However, the dataset has been updated since, in 2021. Currently the source footer shows as Potapov et al. (2017) (2021), which is not ideal.

What do you think is the best solution here? Potapov et al. (2017), which is what the author requested or Potapov et al. (2021) which is perhaps closer to what the dataset reference should be.

@owidbot
Copy link
Contributor

owidbot commented May 8, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-forests-ifl

Chart diff: No new or modified charts. Details

Edited: 2024-05-13 16:20:12 UTC
Execution time: 1.62 seconds

@spoonerf spoonerf requested a review from pabloarosado May 8, 2024 12:19
@spoonerf spoonerf marked this pull request as ready for review May 8, 2024 12:20
Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I just left very minor suggestions, feel free to ignore them.

@@ -0,0 +1,9 @@
steps:
# Intact Forest Landscapes
data://meadow/forests/2024-05-08/ifl:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more useful to spell out this acronym, since there are many IFL things, and this one is not particularly well known (at least to me). But if it's too much hassle, you can leave it as-is.

snapshots/forests/2024-05-08/ifl.py Show resolved Hide resolved
snapshots/forests/2024-05-08/ifl.xlsx.dvc Outdated Show resolved Hide resolved
title: Intact Forest Landscapes Area
unit: square kilometers
short_unit: km²
description_short: Area of [intact forest landscapes](#dod:intact-forest-landscapes). Intact forest landscapes are vast, continuous natural ecosystems without significant human disturbance or fragmentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it a little odd that you have a DoD as well as an explicit explanation. Wouldn't it be enough to simply say:
(A) "Area of intact forest landscapes."
or:
(B) "Area of intact forest landscapes, which are vast, continuous natural ecosystems without significant human disturbance or fragmentation."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little unsure about this, my understanding was that in cases where you can it is best to include a short explanation in the subtitle alongside a DoD. Mainly so that when users screenshot rather than download the chart, as is often the case, a brief explanation of the term is still on the chart.

In this case, the DoD goes more in-depth than the information captured in the description_short.

etl/steps/data/garden/forests/2024-05-08/ifl.py Outdated Show resolved Hide resolved
@pabloarosado
Copy link
Contributor

Regarding the footer, the ideal solution for us and our users would be to use Potapov et al. (2021), which already tells when the data was last updated. I suppose the author is not aware that we include a full citation in the "Learn more about this data" area, and they would be happy with a Potapov et al. (2021) in the footer + a proper citation to the 2017 paper. However, if the data provider (for some reason) strongly prefers citing the paper, then we should respect that, and have Potapov et al. (2017) in the footer.

@spoonerf spoonerf merged commit 5303a3e into master May 14, 2024
5 of 9 checks passed
@spoonerf spoonerf deleted the forests-ifl branch May 14, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants