Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 refactor metadata classes #2697

Merged
merged 1 commit into from
May 29, 2024
Merged

🔨 refactor metadata classes #2697

merged 1 commit into from
May 29, 2024

Conversation

Marigold
Copy link
Collaborator

Move all utility methods into a Base class.

@owidbot
Copy link
Contributor

owidbot commented May 27, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-dry-catalog-meta

chart-diff: ✅ No new or modified charts.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile are not included

Edited: 2024-05-27 13:18:25 UTC
Execution time: 19.60 seconds

Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So clean, thanks! 😍

Maybe can rename this to MetaBase instead? Not really urgent tho...

@Marigold Marigold force-pushed the dry-catalog-meta branch from d36e318 to 922b4c3 Compare May 29, 2024 05:07
@Marigold Marigold merged commit da278aa into master May 29, 2024
5 of 9 checks passed
@Marigold Marigold deleted the dry-catalog-meta branch May 29, 2024 05:09
Marigold added a commit that referenced this pull request May 29, 2024
@Marigold Marigold restored the dry-catalog-meta branch May 29, 2024 06:13
@Marigold Marigold deleted the dry-catalog-meta branch May 29, 2024 06:13
@Marigold Marigold restored the dry-catalog-meta branch May 29, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants