-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📜 data-private #2947
📜 data-private #2947
Conversation
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2024-07-08 15:40:27 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That all makes sense, thanks for writing this up! I left minor suggestions.
|
||
Various privacy configurations are available: | ||
|
||
- Skip re-publishing to GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me what the previous line means.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pabloarosado It means that when it comes to privacy settings, there are various degrees of it.
One can set the snapshot to private, but not the data steps. One make the data available in the catalog, but don't allow the downloading option on Grapher. Whether some of this is confusing, that's discussion we could have I guess.
I got this from #2631
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question was about "Skip re-publishing to GitHub.". Does it mean to the owid-datasets repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. That was my assumption based on Lars' comment here, though I am a bit confused...
docs/guides/private-import.md
Outdated
|
||
### Meadow, Garden, Grapher | ||
|
||
Creating a private data step means that the data is not listed in the public catalog. Also, private datasets will not be re-published to GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's good to clarify what "the public catalog" means. And what "republished to Github" means.
@larsyencken slightly related to this issue #2631, trying to gather all we know from the private steps. Do you think you could have a quick read and see if this makes sense to you? Thanks! |
I will merge this for now and continue the discussion in #2976 |
Add clarifications on private steps.
You can preview the docs by running
and then going to locahost:8000