Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📜 data-private #2947

Merged
merged 3 commits into from
Jul 15, 2024
Merged

📜 data-private #2947

merged 3 commits into from
Jul 15, 2024

Conversation

lucasrodes
Copy link
Member

@lucasrodes lucasrodes commented Jul 8, 2024

Add clarifications on private steps.

You can preview the docs by running

mkdocs serve

and then going to locahost:8000

@lucasrodes lucasrodes requested a review from pabloarosado July 8, 2024 15:39
@owidbot
Copy link
Contributor

owidbot commented Jul 8, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-data-private-docs-4

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-07-08 15:40:27 UTC
Execution time: 14.84 seconds

@lucasrodes lucasrodes marked this pull request as ready for review July 8, 2024 15:40
Copy link
Contributor

@pabloarosado pabloarosado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That all makes sense, thanks for writing this up! I left minor suggestions.


Various privacy configurations are available:

- Skip re-publishing to GitHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me what the previous line means.

Copy link
Member Author

@lucasrodes lucasrodes Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pabloarosado It means that when it comes to privacy settings, there are various degrees of it.

One can set the snapshot to private, but not the data steps. One make the data available in the catalog, but don't allow the downloading option on Grapher. Whether some of this is confusing, that's discussion we could have I guess.

I got this from #2631

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My question was about "Skip re-publishing to GitHub.". Does it mean to the owid-datasets repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question. That was my assumption based on Lars' comment here, though I am a bit confused...


### Meadow, Garden, Grapher

Creating a private data step means that the data is not listed in the public catalog. Also, private datasets will not be re-published to GitHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's good to clarify what "the public catalog" means. And what "republished to Github" means.

@lucasrodes lucasrodes requested a review from larsyencken July 8, 2024 16:26
@lucasrodes
Copy link
Member Author

@larsyencken slightly related to this issue #2631, trying to gather all we know from the private steps. Do you think you could have a quick read and see if this makes sense to you? Thanks!

@lucasrodes
Copy link
Member Author

I will merge this for now and continue the discussion in #2976

@lucasrodes lucasrodes merged commit 8211b54 into master Jul 15, 2024
12 checks passed
@lucasrodes lucasrodes deleted the data-private-docs-4 branch July 15, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants