Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐝 Bump python version #3593

Merged
merged 4 commits into from
Nov 26, 2024
Merged

🐝 Bump python version #3593

merged 4 commits into from
Nov 26, 2024

Conversation

Marigold
Copy link
Collaborator

@Marigold Marigold commented Nov 22, 2024

Partly fixes #3542.

Increase range of python versions from >=3.9,<3.12 to >=3.9,<3.13 (include 3.12). I've tried 3.13 too, but torch didn't have a distribution for 3.13, yet (the problem could be pinning torch to 2.2.2).

I've also discovered bug that was causing all unit tests run against 3.10 🤦 (thank you Makefile!). Luckily, only owid-catalog with 3.9 was affected.

The simplest way to upgrade your python version is to run PYTHON_VERSION=3.12 make .venv.

TODO

  • Add 3.12 to all buildkite jobs

TODO after merging

  • Delete soft_fail from all buildkite jobs
  • Let others know they can upgrade

@owidbot
Copy link
Contributor

owidbot commented Nov 22, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-update-python

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-11-22 10:32:06 UTC
Execution time: 14.90 seconds

@Marigold Marigold requested a review from lucasrodes November 25, 2024 06:07
Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks, Mojmir

@Marigold Marigold marked this pull request as ready for review November 26, 2024 09:37
@Marigold Marigold merged commit c5adbd0 into master Nov 26, 2024
16 checks passed
@Marigold Marigold deleted the update-python branch November 26, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencies: support for Python 3.12, 3.13
3 participants