Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly fixes #3542.
Increase range of python versions from
>=3.9,<3.12
to>=3.9,<3.13
(include 3.12). I've tried 3.13 too, buttorch
didn't have a distribution for 3.13, yet (the problem could be pinning torch to 2.2.2).I've also discovered bug that was causing all unit tests run against 3.10 🤦 (thank you Makefile!). Luckily, only
owid-catalog
with 3.9 was affected.The simplest way to upgrade your python version is to run
PYTHON_VERSION=3.12 make .venv
.TODO
TODO after merging
soft_fail
from all buildkite jobs