-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📊 wb: Update poverty projections in Shared Prosperity report #3679
Conversation
Quick links (staging server):
Login: chart-diff: ✅
data-diff: ✅ No differences foundLegend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2024-12-05 14:30:36 UTC |
@lucasrodes Could you please review this one? I might remove the country level, and I will play with the charts, but the data side is done. There is a unit-tests check failing, but seems to be unrelated to this PR. |
display: | ||
name: Share of population living below $<<povertyline>> a day (<<scenario>>) | ||
numDecimalPlaces: 1 | ||
isProjection: {definitions.isprojection_by_scenario} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit might not working, maybe we need to loosen the boolean restriction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just left minor suggestion, maybe you were not aware of the trick :3
Main issue https://github.com/owid/owid-issues/issues/1705