Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📊 wb: Update poverty projections in Shared Prosperity report #3679

Merged
merged 11 commits into from
Dec 5, 2024

Conversation

paarriagadap
Copy link
Contributor

@paarriagadap paarriagadap commented Dec 3, 2024

@owidbot
Copy link
Contributor

owidbot commented Dec 3, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-data-poverty-projections-shared

chart-diff: ✅
  • 4/4 reviewed charts
  • Modified: 0/0
  • New: 4/4
  • Rejected: 0
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2024-12-05 14:30:36 UTC
Execution time: 6.62 seconds

@paarriagadap paarriagadap marked this pull request as ready for review December 3, 2024 18:25
@paarriagadap
Copy link
Contributor Author

@lucasrodes Could you please review this one? I might remove the country level, and I will play with the charts, but the data side is done.

There is a unit-tests check failing, but seems to be unrelated to this PR.

display:
name: Share of population living below $<<povertyline>> a day (<<scenario>>)
numDecimalPlaces: 1
isProjection: {definitions.isprojection_by_scenario}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit might not working, maybe we need to loosen the boolean restriction

Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left minor suggestion, maybe you were not aware of the trick :3

@paarriagadap paarriagadap merged commit 1fc6eec into master Dec 5, 2024
7 of 8 checks passed
@paarriagadap paarriagadap deleted the data-poverty-projections-shared branch December 5, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants