Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Check variables metadata by default #4052

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pabloarosado
Copy link
Contributor

@pabloarosado pabloarosado commented Feb 28, 2025

I think by now we can safely use check_variables_metadata=True by default (in create_dataset), and remove it from wizard data step templates (which takes a lot of room).
Note that, as far as I can tell, there's little risk in setting this as True by default (maybe we'll see some additional warnings in old steps that didn't have this flag defined explicitly).

@owidbot
Copy link
Contributor

owidbot commented Feb 28, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-enhance-variables-metadata-d

chart-diff: ✅ No charts for review.
data-diff: ✅ No differences found
Legend: +New  ~Modified  -Removed  =Identical  Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippet

Automatically updated datasets matching weekly_wildfires|excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included

Edited: 2025-02-28 15:31:28 UTC
Execution time: 17.71 seconds

@pabloarosado pabloarosado marked this pull request as ready for review February 28, 2025 15:42
Copy link
Member

@lucasrodes lucasrodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants