Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip content not nicely formatted when variable name is long and a time notice is displayed #2714

Closed
sophiamersmann opened this issue Oct 9, 2023 · 9 comments · Fixed by #3907

Comments

@sophiamersmann
Copy link
Member

The tooltip content is weirdly formatted when the variable name is long and a time notice is displayed.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to https://ourworldindata.org/explorers/coronavirus-data-explorer?zoomToSelection=true&facet=none&country=BHR~BRA~CHL~FRA~DEU~HUN~IND~ISR~SRB~TUR~GBR~USA~URY~ESP~ITA~ARE~MEX~RUS&pickerSort=desc&pickerMetric=population&hideControls=true&Interval=Cumulative&Relative+to+Population=true&Color+by+test+positivity=false&Metric=People+vaccinated+%28by+dose%29
  2. Hover over the "Italy" bar
  3. Note that the tooltip content is not formatted nicely

Screenshots

Screenshot 2023-10-09 at 16 11 57
@ikesau
Copy link
Member

ikesau commented Oct 17, 2023

@samizdatco is this just a matter of some max-widths here and there? famous last words but that seems simple enough?

@parthiv360
Copy link
Contributor

Hey @sophiamersmann can I work on this issue?

@sophiamersmann
Copy link
Member Author

Sure!

@parthiv360
Copy link
Contributor

Hey @sophiamersmann can you please suggest how to traverse to this page in localhost. Thank you

@ikesau
Copy link
Member

ikesau commented Oct 25, 2023

If your localhost route isn't loading for you (or any explorer, for that matter) you might be missing https://github.com/owid/owid-content

Clone it into the same directory that contains this repo and then restart your local server 🙂

@parthiv360
Copy link
Contributor

Okay Thanks.

@parthiv360
Copy link
Contributor

parthiv360 commented Oct 26, 2023

Hey @ikesau I have gone through this issue and was trying to correct it. I have tracked the pages were the potential changes need to be done.

I have a confusion that do I need to change the container size to adjust the time or adjust the time or something keeping the size of container fixed.

Or can you please suggest any particular solution that I can implement.

Thank you.

@parthiv360
Copy link
Contributor

Hey @sophiamersmann I have raised a PR. Can you please review it and suggest any changes required? Thank you.

Copy link

This issue has had no activity within 10 months. It is considered stale and will be closed in 7 days unless it is worked on or tagged as pinned.

@github-actions github-actions bot added the stale label Aug 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
toni-sharpe added a commit to toni-sharpe/owid-grapher that referenced this issue Sep 3, 2024
* Fixes: owid#2714 long line length - note that I think these will still wrap as the only change is the date nowrap addition.
* This will be why I opted for `vw` unit to minimise the long line outcome.
* The same line fixes the problem Lucas was having: wrapping dates.
toni-sharpe added a commit to toni-sharpe/owid-grapher that referenced this issue Sep 3, 2024
* Fixes: owid#2714 long line length - note that I think these will still wrap as the only change is the date nowrap addition.
* This will be why I opted for `vw` unit to minimise the long line outcome.
* The same line fixes the problem Lucas was having in owid#3817: wrapping dates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants