-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2714 & 3817: Fix tooltip layout with long lines #3907
Conversation
8fc900f
to
88ad0f8
Compare
@danyx23 hello :-) The new tag and system underneath (which addressed my concern here) is great, but I noitice this PR doesn't have it applied? Perhaps it could auto-apply if the contribution is not part of some team, or, the contriubutor could have access to add it themselves? @lucasrodes @sophiamersmann tagged as you raised the two issues I think I fixed with this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! I think adding nowrap
to the time notice cell should be all that is needed here.
- changed
400px
to80vw
which is more responsive anyway, but was also needed to catch longer rows with dates
Can you change this back to 400px? Using a fixed width makes more sense here.
white-space: nowrap
kept the date from breaking line
This works well!
- combining the swatch colour with name avoided the problem with
<table />
guessing at widths which made a huge gap between swatch and name
I'm not sure what you mean, but the changes mess with the layout of the "Total" row. Can you please revert?
@sophiamersmann - hello, hope you're well, and no problem, I'm one of the not so common ones that enjoys CSS. re: "combining the swatch colour .... huge gap between swatch and name" - this was occuring in cases where my change to But fixing it to Curious: where is the total row? What did the mess up look like? No expectations. |
@sophiamersmann not sure I'm even seeing that row (unless it's being used for the additional info bit, as this uses % and 100% is implied by that): But I can see that I'll get this sorted later today (have to go out) but well beyond business hours. |
4826f40
to
6ee52b0
Compare
@sophiamersmann this should now be done (though I have not tested in your issue's context) You now have one commit that applies nowrap to fix dates. With your issue I assume it was just the date wrapping? Without testing, it should now have a flat date and wrapped text in the box. My |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
vw
unit to minimise the long line outcome.[OUT OF DATE]