redesign: render thumbnails at a larger font size #2749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sophiamersmann, if you could take a look at 0a31261 for a moment that would be great.
Basically, the rationale is that if a title spans two or more lines, then we benefit from the font size reduction even if that doesn't reduce the number of lines.
I also changed the font size reduction to a maximum of 20% rather than cap it at 2px. It's just another arbitrary number, so feel free to change.
In theory we could also make this behavior dependent on the
isGeneratingThumbnail
flag, so let me know what you think.Here are some thumbnails rendered using the worker. The last three have a reduced title font size.