Grapher redesign: Prevent chart icon to unexpectedly change #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sophiamersmann
commented
Oct 12, 2023
sophiamersmann
commented
- Fixes a bug where the chart icon would unexpectedly change from a line chart icon into a bar chart icon when clicking on the map tab
- This happens because switching from a line chart to the map automatically sets the timeline to a single year, and the underlying chart switches to a discrete bar chart
- To prevent that, we hold onto the previous chart icon if we're not currently on the chart tab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.