Entry Emulator - hide sticky nav on linear topic pages #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikesau
force-pushed
the
entry-emulator-no-sticky-nav
branch
from
fdb65a9 to
a6fce45
Compare
|
Yeah looks good! Just add it to the documentation and maybe tell authors briefly about it in some slack channel :) |
danyx23
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it a hack if you use the code as was intended? 😁
This adds an empty array to the gdoc content object's
sticky-navproperty, which causes the sticky nav to not render.It was either this, or some sort of flag to hide the sticky nav. This seemed like the less intrusive way to handle it.
example:
archie excerpt: