Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data pages: Extract data page component IndicatorBrief #2839

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Oct 24, 2023

This PR extracts the part below the grapher chart into a separate component in the components repo

The SVG Tester shows two changed charts - these are because the shortened text that we show for the sources on the chart itself has slightly changed if there are more than 3 origins

@danyx23 danyx23 changed the title data-page-shared-components Extract data page component IndicatorBrief Oct 24, 2023
@danyx23 danyx23 marked this pull request as ready for review October 24, 2023 14:38
@danyx23 danyx23 changed the title Extract data page component IndicatorBrief Data pages: Extract data page component IndicatorBrief Oct 24, 2023
Base automatically changed from 10-19-data-page-better-citations to master October 24, 2023 16:30
@danyx23 danyx23 merged commit e46c79d into master Oct 24, 2023
11 of 13 checks passed
@danyx23 danyx23 deleted the 10-24-data-page-shared-components branch October 24, 2023 16:30
Copy link
Contributor Author

danyx23 commented Oct 24, 2023

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants