Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (scatter) rotate y-axis label #4331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Dec 18, 2024

Rotates the y-axis labels for scatter plots to make them horizontal and easier to read.

It would be nice if we also rotated the y-axis label for Marimekko charts, but for Marimekko charts with an x-dimension, the x-axis labels are plotted above the chart area (see screenshot). It would be confusing if we showed both labels on the same line.

I also tried right-aligning x-axis labels, but it often looked unbalanced.

Example of a Mariemkko chart with a x-dimension

Screenshot 2025-01-02 at 15 33 03


This is part 1 of 3 in a stack made with GitButler:

Copy link
Member Author

sophiamersmann commented Dec 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@owidbot
Copy link
Contributor

owidbot commented Dec 18, 2024

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-scatter-axis-labels-viz

SVG tester:

Number of differences (default views): 451 (7c0a23) ❌
Number of differences (all views): 375 (7a5fa1) ❌

Edited: 2025-01-09 15:29:07 UTC
Execution time: 1.30 seconds

@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from cf5e224 to 61ff9a3 Compare December 18, 2024 16:09
@sophiamersmann sophiamersmann changed the title ✨ (scatter) show horizontal x-axis label ✨ (scatter) show horizontal y-axis label Dec 20, 2024
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 61ff9a3 to 679df95 Compare December 20, 2024 15:03
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 679df95 to e4bd5e5 Compare January 2, 2025 13:11
@sophiamersmann sophiamersmann changed the base branch from master to fix-flaky-test-marimekko January 2, 2025 13:11
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 2, 2025
@owid owid deleted a comment from coderabbitai bot Jan 2, 2025
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch 3 times, most recently from 9e037de to 610242e Compare January 2, 2025 13:55
@sophiamersmann sophiamersmann changed the title ✨ (scatter) show horizontal y-axis label ✨ (scatter) rotate y-axis label Jan 2, 2025
@owid owid deleted a comment from graphite-app bot Jan 2, 2025
@sophiamersmann sophiamersmann marked this pull request as ready for review January 2, 2025 14:36
@sophiamersmann sophiamersmann changed the base branch from fix-flaky-test-marimekko to graphite-base/4331 January 2, 2025 14:40
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 610242e to 113fcbe Compare January 2, 2025 14:40
@sophiamersmann sophiamersmann changed the base branch from graphite-base/4331 to master January 2, 2025 14:40
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 113fcbe to 04daaca Compare January 2, 2025 14:40
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from 04daaca to 84e6485 Compare January 8, 2025 10:34
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch 2 times, most recently from 0f6ed49 to d95a8ab Compare January 9, 2025 12:52
@sophiamersmann sophiamersmann force-pushed the scatter-axis-labels-viz branch from d95a8ab to 721caf1 Compare January 9, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants