-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (scatter) rotate y-axis label #4331
Open
sophiamersmann
wants to merge
1
commit into
master
Choose a base branch
from
scatter-axis-labels-viz
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+106
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2024
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 451 (7c0a23) ❌ Edited: 2025-01-09 15:29:07 UTC |
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
December 18, 2024 16:09
cf5e224
to
61ff9a3
Compare
sophiamersmann
changed the title
✨ (scatter) show horizontal x-axis label
✨ (scatter) show horizontal y-axis label
Dec 20, 2024
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
December 20, 2024 15:03
61ff9a3
to
679df95
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 2, 2025 13:11
679df95
to
e4bd5e5
Compare
sophiamersmann
changed the base branch from
master
to
fix-flaky-test-marimekko
January 2, 2025 13:11
Merged
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
3 times, most recently
from
January 2, 2025 13:55
9e037de
to
610242e
Compare
sophiamersmann
changed the title
✨ (scatter) show horizontal y-axis label
✨ (scatter) rotate y-axis label
Jan 2, 2025
sophiamersmann
changed the base branch from
fix-flaky-test-marimekko
to
graphite-base/4331
January 2, 2025 14:40
sophiamersmann
force-pushed
the
graphite-base/4331
branch
from
January 2, 2025 14:40
9fc8471
to
9319dae
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 2, 2025 14:40
610242e
to
113fcbe
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 2, 2025 14:40
113fcbe
to
04daaca
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 8, 2025 10:34
04daaca
to
84e6485
Compare
This was referenced Jan 8, 2025
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
2 times, most recently
from
January 9, 2025 12:52
0f6ed49
to
d95a8ab
Compare
sophiamersmann
force-pushed
the
scatter-axis-labels-viz
branch
from
January 9, 2025 15:09
d95a8ab
to
721caf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotates the y-axis labels for scatter plots to make them horizontal and easier to read.
It would be nice if we also rotated the y-axis label for Marimekko charts, but for Marimekko charts with an x-dimension, the x-axis labels are plotted above the chart area (see screenshot). It would be confusing if we showed both labels on the same line.
I also tried right-aligning x-axis labels, but it often looked unbalanced.
Example of a Mariemkko chart with a x-dimension
This is part 1 of 3 in a stack made with GitButler: