Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use yarn via corepack #4393

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

chore: use yarn via corepack #4393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ccac77e
chore(yarn): use latest yarn version, via corepack
marcelgerber Dec 22, 2024
4874560
chore(ci): enable corepack
marcelgerber Dec 22, 2024
408f481
docs: update docs accordingly
marcelgerber Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/actions/setup-node-yarn-deps/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ description: Runs all the setup steps required to have the proper Node version a
runs:
using: composite
steps:
# Corepack must be enabled _before_ running setup-node, otherwise the caching setup will error
- name: Enable corepack
run: corepack enable
shell: bash

- name: Use Node.js (.nvmrc)
uses: actions/setup-node@v4
with:
Expand Down
893 changes: 0 additions & 893 deletions .yarn/releases/yarn-4.1.1.cjs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,3 @@ logFilters:
level: discard

nodeLinker: node-modules

yarnPath: .yarn/releases/yarn-4.1.1.cjs
4 changes: 2 additions & 2 deletions docs/local-typescript-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,10 @@ Note: on Windows we strongly recommend using the [Windows Subsystem for Linux](h

(this will pick up the right version from `.nvmrc`)

5. Install yarn:
5. Enable [Corepack](https://nodejs.org/docs/latest-v22.x/api/corepack.html), which provides `yarn` versions:

```sh
npm install -g yarn
corepack enable
```

6. Run yarn inside the repo folder to install dependencies:
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"engines": {
"node": ">=18.16"
},
"packageManager": "yarn@4.1.1",
"packageManager": "yarn@4.6.0",
"scripts": {
"batchTagWithGpt": "tsx --tsconfig tsconfig.tsx.json baker/batchTagWithGpt.ts",
"buildCoverage": "jest --coverage=true --coverageProvider=v8",
Expand Down
4 changes: 2 additions & 2 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19992,11 +19992,11 @@ __metadata:

"typescript@patch:typescript@npm%3A>=3 < 6#optional!builtin<compat/typescript>, typescript@patch:typescript@npm%3A~5.7.2#optional!builtin<compat/typescript>":
version: 5.7.2
resolution: "typescript@patch:typescript@npm%3A5.7.2#optional!builtin<compat/typescript>::version=5.7.2&hash=5adc0c"
resolution: "typescript@patch:typescript@npm%3A5.7.2#optional!builtin<compat/typescript>::version=5.7.2&hash=5786d5"
bin:
tsc: bin/tsc
tsserver: bin/tsserver
checksum: 10/ff27fc124bceb8969be722baa38af945b2505767cf794de3e2715e58f61b43780284060287d651fcbbdfb6f917f4653b20f4751991f17e0706db389b9bb3f75d
checksum: 10/d75ca10141afc64fd3474b41a8b082b640555bed388d237558aed64e5827ddadb48f90932c7f4205883f18f5bcab8b6a739a2cfac95855604b0dfeb34bc2f3eb
languageName: node
linkType: hard

Expand Down
Loading