Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ use 'nice' axis ticks for linear scales #4404

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jan 8, 2025

Resolves #3978

See 3790bad 😅

If any data value is just above a grid line, then the old behaviour is nicer since showing an additional grid line 'squishes' the rest of the chart. Here are some examples:

Screenshot 2025-01-09 at 11 55 45 Screenshot 2025-01-09 at 11 56 29

Here is another case where the y-axis min is set to 14 and that's why the 10 grid line is now included:

Screenshot 2025-01-09 at 11 55 32

@owidbot
Copy link
Contributor

owidbot commented Jan 8, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-nice-axis-ticks

SVG tester:

Number of differences (default views): 175 (ad0b7c) ❌
Number of differences (all views): 57 (e8297b) ❌

Edited: 2025-01-09 15:27:38 UTC
Execution time: 1.26 seconds

@sophiamersmann sophiamersmann force-pushed the nice-axis-ticks branch 2 times, most recently from 5dc4d1c to 0a553e6 Compare January 8, 2025 13:47
@sophiamersmann sophiamersmann changed the title ✨ (line) use 'nice' axis ticks ✨ use 'nice' axis ticks for linear scales Jan 8, 2025
@sophiamersmann sophiamersmann added the staging-viz Let SVG tester fail silently in CI label Jan 8, 2025
@sophiamersmann sophiamersmann force-pushed the nice-axis-ticks branch 3 times, most recently from 1e14c4c to 6cc31a6 Compare January 9, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
staging-viz Let SVG tester fail silently in CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal grid lines: adding these more frequently
2 participants