Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin): allow tagging on the chart basic tab #4506

Merged
merged 3 commits into from
Jan 31, 2025
Merged

feat(admin): allow tagging on the chart basic tab #4506

merged 3 commits into from
Jan 31, 2025

Conversation

marcelgerber
Copy link
Member

@marcelgerber marcelgerber commented Jan 30, 2025 •
edited
Loading

Resolves #4501.

CleanShot 2025-01-30 at 18 38 50

@marcelgerber marcelgerber marked this pull request as ready for review January 30, 2025 17:39
@owidbot
Copy link
Contributor

owidbot commented Jan 30, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-chart-page-tagging

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-01-30 18:03:54 UTC
Execution time: 1.21 seconds

sophiamersmann
sophiamersmann approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@sophiamersmann sophiamersmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah, I love a quick life improvement pr 🚀

@marcelgerber marcelgerber merged commit 1401cf2 into master Jan 31, 2025
18 of 19 checks passed
@marcelgerber marcelgerber deleted the chart-page-tagging branch January 31, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiamersmann sophiamersmann sophiamersmann approved these changes

Assignees

@marcelgerber marcelgerber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit chart tags inside the chart editor
3 participants
@marcelgerber @owidbot @sophiamersmann