🐛 fix admin API error messages not showing in client #4564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-14 18:54:33 UTC |
ikesau
commented
Feb 14, 2025
| const json = await response.json() | ||
|
|
||
| if (verifySuccess) { | ||
| expect(response.status).toBe(200) |
There was a problem hiding this comment.
tests would now fail without making this change, but it kind of begs the question: why have success = true and status = 200
🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
return { success: false, error: "Oh no!" }was being used in a few places in our API, but the admin client didn't understand what to do with that response.Fix
I grep'd
return {in the API folder, and updated any instance of the non-working pattern withthrow new JsonError(instead.To test
Check this branch out, go to
http://localhost:3030/admin/charts/createand click "Create Draft"The error that throws (due to missing data) will render correctly in the client.