Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-dims to data catalog #4629

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Add multi-dims to data catalog #4629

merged 1 commit into from
Mar 7, 2025

Conversation

rakyi
Copy link
Contributor

@rakyi rakyi commented Mar 5, 2025

Resolves #4454

@rakyi rakyi requested a review from marcelgerber March 5, 2025 13:41
@@ -88,7 +89,7 @@ export enum SearchIndexName {
ExplorerViews = "explorer-views",
Charts = "charts",
Pages = "pages",
ExplorerViewsAndCharts = "explorer-views-and-charts",
Copy link
Contributor Author

@rakyi rakyi Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the index itself would be a lot of overhead, so I didn't do it. I think we can live with the old name.

@rakyi rakyi force-pushed the index-mdims-in-algolia branch 2 times, most recently from bb19482 to 05eece1 Compare March 5, 2025 14:08
@owidbot
Copy link
Contributor

owidbot commented Mar 5, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-index-mdims-in-algolia

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-03-05 14:20:38 UTC
Execution time: 1.20 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good!

@rakyi rakyi force-pushed the index-mdims-in-algolia branch from 05eece1 to a905527 Compare March 6, 2025 15:05
@rakyi rakyi force-pushed the index-mdims-in-algolia branch from a905527 to e898c1d Compare March 7, 2025 10:44
@rakyi rakyi merged commit 3ad6c45 into master Mar 7, 2025
22 of 24 checks passed
@rakyi rakyi deleted the index-mdims-in-algolia branch March 7, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multidimensional data page views to data catalog
3 participants