-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH implement local fit for trend curve #234
Draft
BorisMuzellec
wants to merge
16
commits into
main
Choose a base branch
from
local_trend_fit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
… parametric trend curve in default inference model
BorisMuzellec
changed the title
ENH implement local fit for trend curve (WIP)
ENH implement local fit for trend curve
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue or PRs
Fixes #231
What does your PR implement? Be specific.
Implement a "local" option for the trend curve using scikit-misc's loess implementation.
A few issues to work on:
scikit-misc
loess
objects are unpicklable. As a result, using a"local"
curve fit makes theDeseqDataSet
object unpicklable.On some platforms (Ubuntu in particular),
loess
will cause a segmentation fault, which is not possible to catch using pythontry ... except ...
. As a workaround,loess
is run in a separate process, to avoid the main process crashing in case of a segfault. This is a bit cumbersome, because the child process cannot communicate the fittedloess
object to the main, as it is unpicklable. The current solution is toloess
in the main process