Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: robust attribute overwriting logic #4

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix: robust attribute overwriting logic #4

merged 2 commits into from
Jan 19, 2024

Conversation

honghaoli42
Copy link
Collaborator

Only overwrite the robust attribute if the argument robust is not None

@honghaoli42
fix: robust attribute overwriting logic
6310977 
Only overwrite the `robust` attribute if the argument `robust` is not None
@honghaoli42 honghaoli42 requested a review from jeandut as a code owner January 19, 2024 11:06
@honghaoli42 honghaoli42 requested a review from a user January 19, 2024 11:06
@jeandut jeandut merged commit e7be88b into main Jan 19, 2024
4 of 6 checks passed
@jeandut jeandut deleted the honghao/fix_arg_robust branch January 19, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandut jeandut Awaiting requested review from jeandut jeandut is a code owner

@qklopfenstein-owkin qklopfenstein-owkin Awaiting requested review from qklopfenstein-owkin qklopfenstein-owkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honghaoli42 @jeandut