Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honghao/power tie dp #5

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Honghao/power tie dp #5

merged 4 commits into from
Jan 23, 2024

Conversation

honghaoli42
Copy link
Collaborator

  • Experiment configs for power-tie and power-dp analyses
  • Replace prints with logging messages to have control in the log file

@honghaoli42 honghaoli42 requested a review from jeandut as a code owner January 22, 2024 13:27
@honghaoli42 honghaoli42 requested a review from a user January 22, 2024 13:27
jeandut
jeandut approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@jeandut jeandut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeandut
Copy link
Collaborator

jeandut commented Jan 23, 2024

Can you rebase and merge @honghaoli42 ?

@honghaoli42 honghaoli42 merged commit d0efbad into main Jan 23, 2024
6 checks passed
@honghaoli42 honghaoli42 deleted the honghao/power_tie_dp branch January 23, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeandut jeandut jeandut approved these changes

@qklopfenstein-owkin qklopfenstein-owkin Awaiting requested review from qklopfenstein-owkin qklopfenstein-owkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@honghaoli42 @jeandut