Skip to content

Commit

Permalink
PHPStan
Browse files Browse the repository at this point in the history
  • Loading branch information
ilestis committed Jan 6, 2025
1 parent 0de8ff3 commit 2160216
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 14 deletions.
3 changes: 1 addition & 2 deletions app/Http/Controllers/Families/FamilyController.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ public function index(Campaign $campaign, Family $family)
$filters['parent'] = $family->id;
}
Datagrid::layout(\App\Renderers\Layouts\Family\Family::class)
->route('families.families', $options)
;
->route('families.families', $options);

$this->rows = $family

Check failure on line 33 in app/Http/Controllers/Families/FamilyController.php

View workflow job for this annotation

GitHub Actions / PHP 8.3

Call to an undefined method Staudenmeir\LaravelAdjacencyList\Eloquent\Relations\Descendants<Illuminate\Database\Eloquent\Model, App\Models\Family>::sort().
->descendants()
Expand Down
1 change: 0 additions & 1 deletion app/Http/Controllers/Items/EntityController.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ public function index(Campaign $campaign, Item $item)
Datagrid::layout(\App\Renderers\Layouts\Item\Entity::class)
->route('items.inventories', $options);

// @phpstan-ignore-next-line
$this->rows = $item
->entities()
->sort(request()->only(['o', 'k']), ['name' => 'asc'])
Expand Down
10 changes: 0 additions & 10 deletions app/Http/Controllers/Settings/AccountController.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ public function __construct(DeletionService $deletionService)
$this->deletionService = $deletionService;
}

/**
* @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
*/
public function index()
{
$user = auth()->user();
Expand All @@ -54,8 +51,6 @@ public function password(StoreSettingsAccount $request)
->with('success', __('settings.account.password_success'));
}

/**
*/
public function email(StoreSettingsAccountEmail $request)
{
if ($request->ajax()) {
Expand All @@ -69,9 +64,6 @@ public function email(StoreSettingsAccountEmail $request)
->with('success', __('settings.account.email_success'));
}

/**
* @return \Illuminate\Http\RedirectResponse
*/
public function social(StoreSettingsAccountSocial $request)
{
if (empty(auth()->user()->provider)) {
Expand All @@ -96,8 +88,6 @@ public function social(StoreSettingsAccountSocial $request)
->with('success', __('settings.account.social.success'));
}

/**
*/
public function destroy(DeleteSettingsAccount $request)
{
if ($request->ajax()) {
Expand Down
2 changes: 1 addition & 1 deletion app/Traits/Controllers/HasDatagrid.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
namespace App\Traits\Controllers;

use App\Facades\Datagrid;
use Illuminate\Pagination\LengthAwarePaginator;
use Illuminate\Contracts\Pagination\LengthAwarePaginator;

trait HasDatagrid
{
Expand Down

0 comments on commit 2160216

Please sign in to comment.