Fix phpstan

owlchester · Dec 5, 2023 · 463e1b4 · 463e1b4
1 parent 7453d4d
commit 463e1b4
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 5 deletions.
diff --git a/app/Http/Controllers/CrudController.php b/app/Http/Controllers/CrudController.php
@@ -13,6 +13,7 @@
 use App\Models\Entity;
 use App\Models\AttributeTemplate;
 use App\Models\Bookmark;
+use App\Models\Family;
 use App\Models\MiscModel;
 use App\Sanitizers\MiscSanitizer;
 use App\Services\MultiEditingService;
@@ -156,6 +157,7 @@ public function crudIndex(Request $request)
         // Do this to avoid an extra sql query when no filters are selected
         if ($this->filterService->hasFilters()) {
             $unfilteredCount = $base->count();
+            // @phpstan-ignore-next-line
             $base = $base->filter($this->filterService->filters());
 
             $models = $base->paginate();

diff --git a/app/Http/Controllers/Front/HelperController.php b/app/Http/Controllers/Front/HelperController.php
@@ -2,6 +2,7 @@
 
 namespace App\Http\Controllers\Front;
 
+use App\Models\Family;
 use App\Models\MiscModel;
 use Exception;
 use Illuminate\Support\Str;
@@ -29,6 +30,7 @@ public function apiFilters()
             if (!$misc instanceof MiscModel) {
                 abort(404);
             }
+            // @phpstan-ignore-next-line
             $filters = $misc->getFilterableColumns();
 
             return view('helpers.api-filters', compact(

diff --git a/app/Http/Requests/StoreAbilityEntity.php b/app/Http/Requests/StoreAbilityEntity.php
@@ -26,10 +26,8 @@ public function rules()
         return [
             'ability_id' => 'required|exists:entities,id',
             'visibility_id' => 'required|exists:visibilities,id',
-            'entities' => 'required',
-            'entities' => [
-                '*' => 'different:ability_id|exists:entities,id',
-            ],
+            'entities' => 'array|required',
+            'entities.*' => ['different:ability_id|exists:entities,id'],
         ];
     }
 }
diff --git a/app/Models/CampaignDashboardWidget.php b/app/Models/CampaignDashboardWidget.php
@@ -264,7 +264,7 @@ public function entities()
         $entityType = $this->conf('entity');
         if (!empty($entityType) && !empty($this->config['filters'])) {
             $className = 'App\Models\\' . Str::studly($entityType);
-            /** @var MiscModel|Character $model */
+            /** @var Character|mixed $model */
             $model = new $className();
 
             /** @var FilterService $filterService */
@@ -320,6 +320,7 @@ public function randomEntity()
                 ->model($model)
                 ->make($entityType);
 
+            // @phpstan-ignore-next-line
             $models = $model
                 ->select($model->getTable() . '.id')
                 ->filter($filterService->filters())

diff --git a/app/Services/Campaign/ExportService.php b/app/Services/Campaign/ExportService.php
@@ -211,6 +211,7 @@ protected function smartWith(array $with, string $entityClass): array
     {
         /** @var MiscModel $class */
         $class = app()->make($entityClass);
+        // @phpstan-ignore-next-line
         foreach ($class->exportRelations() as $rel) {
             $with[] = $rel;
         }

diff --git a/app/Traits/TreeControllerTrait.php b/app/Traits/TreeControllerTrait.php
@@ -98,6 +98,7 @@ public function tree(Request $request, Campaign $campaign)
         // Do this to avoid an extra sql query when no filters are selected
         if ($this->filterService->hasFilters()) {
             $unfilteredCount = $base->count();
+            // @phpstan-ignore-next-line
             $base = $base->filter($this->filterService->filters());
 
             $models = $base->paginate();