Skip to content

Commit

Permalink
Implemented requested changes
Browse files Browse the repository at this point in the history
  • Loading branch information
spitfire305 committed Jan 6, 2024
1 parent cf3513c commit 665fbce
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 18 deletions.
8 changes: 0 additions & 8 deletions app/Models/CampaignDashboardWidget.php
Original file line number Diff line number Diff line change
Expand Up @@ -248,14 +248,6 @@ public function entities()
;
}

if ($this->conf('created_by')) {
$base = $base->where('created_by', $this->conf('created_by'));
}

if ($this->conf('updated_by')) {
$base = $base->where('updated_by', $this->conf('updated_by'));
}

// Ordering
$order = Arr::get($this->config, 'order', null);
if (empty($order)) {
Expand Down
2 changes: 0 additions & 2 deletions lang/en/dashboard.php
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,12 @@
],
'fields' => [
'class' => 'CSS class',
'created_by' => 'Created by',
'dashboard' => 'Dashboard',
'name' => 'Custom widget name',
'optional-entity' => 'Link to entity',
'order' => 'Ordering',
'size' => 'Size',
'text' => 'Text',
'updated_by' => 'Last updated by',
'width' => 'Width',
],
'helpers' => [
Expand Down
8 changes: 0 additions & 8 deletions resources/views/dashboard/widgets/forms/_recent.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,14 +80,6 @@
], null, ['class' => '']) !!}
</x-forms.field>
@includeWhen(!empty($dashboards), 'dashboard.widgets.forms._dashboard')

<x-forms.field field="config[created_by]" :label="__('dashboard.widgets.fields.created_by')">
{!! Form::select('config[created_by]', ['' => ''] + $campaign->membersList(), null, ['class' => 'w-full']) !!}
</x-forms.field>

<x-forms.field field="config[updated_by]" :label="__('dashboard.widgets.fields.updated_by')">
{!! Form::select('config[updated_by]', ['' => ''] + $campaign->membersList(), null, ['class' => 'w-full']) !!}
</x-forms.field>
</x-grid>
</div>
<div id="advanced-{{ $mode }}" class="tab-pane fade in">
Expand Down

0 comments on commit 665fbce

Please sign in to comment.