API: Transfer to Campaign Endpoint

app/Http/Controllers/Api/v1/EntityMoveApiController.php

@@ -6,6 +6,7 @@
 use App\Models\Entity;
 use App\Http\Requests\MoveEntity as Request;
 use App\Services\Entity\MoveService;
+use Exception;
 
 class EntityMoveApiController extends ApiController
 {
@@ -25,12 +26,12 @@ public function transfer(Request $request, Campaign $campaign)
     {
         $this->authorize('access', $campaign);
         $count = 0;
-        $copy = null === $request->copy ? true : $request->copy;
-
-        foreach ($request->entities as $id) {
-            $entity = Entity::find($id);
-            if ($this->authorize('update', $entity->child)) {
-                $this->service
+        $copy = is_null($request->copy) ? false : $request->copy;
+        try {
+            foreach ($request->entities as $id) {
+                $entity = Entity::find($id);
+                if ($this->authorize('update', $entity->child)) {
+                    $this->service
                     ->entity($entity)
                     ->campaign($campaign)
                     ->user($request->user())
@@ -39,13 +40,21 @@ public function transfer(Request $request, Campaign $campaign)
                     ->validate()
                     ->process()
                 ;
-                $count++;
+                    $count++;
+                }
             }
-        }
 
-        if ($copy) {
-            return response()->json(['success' => 'Succesfully copied ' . $count . ' entities.']);
+            if ($copy) {
+                return response()->json(['success' => 'Succesfully copied ' . $count . ' entities.']);
+            }
+            return response()->json(['success' => 'Succesfully transfered ' . $count . ' entities.']);
+
+        } catch (Exception $e) {
+            return response()->json([
+                'error' => true,
+                'message' => $e->getMessage(),
+            ]);
         }
-        return response()->json(['success' => 'Succesfully transfered ' . $count . ' entities.']);
+
     }
 }

resources/api-docs/1.0/entities.md

@@ -229,7 +229,7 @@ You can post an array with the ids of the entities you want to transfer to anoth
 | :- | :- | :- |
 | `entities` | `array`(required) | The ids of the entities to transfer or copy. |
 | `campaign_id` | `integer`(required) | The id of the campaign the entity will be transfered or copied to. |
-| `copy` | `boolean` | True if the entity will be copied, false if the entity will be transfered, defaults to copy if left empty |
+| `copy` | `boolean` | True if the entity will be copied, false if the entity will be transfered, defaults to false if left empty |
 
 ### Result
 

tests/Feature/Entities/EntityTest.php

@@ -49,7 +49,6 @@
     ->postJson('/api/1.0/campaigns/1/transfer', [
         'entities' => [1,2,3],
         'campaign_id' => 2,
-        'copy'  => false
     ])
     ->assertJsonFragment(['success' => 'Succesfully transfered 3 entities.'])
     ->assertStatus(200)
@@ -63,6 +62,7 @@
     ->postJson('/api/1.0/campaigns/1/transfer', [
         'entities' => [1,2,3],
         'campaign_id' => 2,
+        'copy'  => true
     ])
     ->assertJsonFragment(['success' => 'Succesfully copied 3 entities.'])
     ->assertStatus(200)