Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Cashier to v15 #858

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Updated Cashier to v15 #858

merged 4 commits into from
Apr 24, 2024

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis April 23, 2024 17:28
ilestis
ilestis requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can find at least on reference to subscriptions.name in the code that isn't updated with this migration. please make sure (stripe and paypal, and manual subs from the admin panel) still work

@spitfire305 spitfire305 requested a review from ilestis April 24, 2024 17:27
ilestis
ilestis requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup now that cashier provides proper model comments

app/Services/PayPalService.php Outdated Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis April 24, 2024 18:34
@ilestis ilestis merged commit a01e93b into develop Apr 24, 2024
1 of 2 checks passed
@ilestis ilestis deleted the update-cashier-15 branch August 8, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilestis ilestis ilestis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spitfire305 @ilestis