Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed filters no filtering properly on is_private #914

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fixed filters no filtering properly on is_private #914

merged 4 commits into from
Jul 11, 2024

Conversation

spitfire305
Copy link
Collaborator

No description provided.

@spitfire305 spitfire305 requested a review from ilestis July 11, 2024 17:06
ilestis
ilestis requested changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy-pasting should leave to alarm bells going on in your brain that you're doing something very wrong :)

app/Models/Character.php Outdated Show resolved Hide resolved
app/Models/Character.php Outdated Show resolved Hide resolved
app/Models/Concerns/HasFilters.php Show resolved Hide resolved
app/Models/Concerns/HasFilters.php Outdated Show resolved Hide resolved
app/Models/Concerns/HasFilters.php Outdated Show resolved Hide resolved
app/Models/Concerns/HasFilters.php Outdated Show resolved Hide resolved
app/Models/Family.php Outdated Show resolved Hide resolved
app/Models/Family.php Outdated Show resolved Hide resolved
app/Models/Organisation.php Outdated Show resolved Hide resolved
app/Models/Organisation.php Outdated Show resolved Hide resolved
@spitfire305 spitfire305 requested a review from ilestis July 11, 2024 19:11
ilestis
ilestis approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@ilestis ilestis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻

@ilestis ilestis merged commit eec9a97 into develop Jul 11, 2024
@ilestis ilestis deleted the character-race-filters branch July 11, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilestis ilestis ilestis approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spitfire305 @ilestis