This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
Fix sharing #624
Open
rullzer
wants to merge
1
commit into
master
Choose a base branch
from
fix_sharing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix sharing #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get the path in the documents app * A new share.js to make it work with the OCS Share API Thanks to @oparoz for the hard work on share.js
in case it matters, the browser's current URL is "http://localhost/owncloud/index.php/apps/documents/index#557" |
mm works here... I'll try to reproduce your bug... |
Same 404 error here with same Request URL. |
Not seeing any 404 errors with this URL or when trying to share inside the documents app.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622
Thanks to @oparoz for the hard work on share.js
It is by far not the cleanest. But to be honest the whole js here is kind of a mess...
Please test and review.