Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Fix sharing #624

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sharing #624

wants to merge 1 commit into from

Conversation

rullzer
Copy link

@rullzer rullzer commented Mar 16, 2016

Fixes #622

  • Get the path in the documents app
  • A new share.js to make it work with the OCS Share API

Thanks to @oparoz for the hard work on share.js

It is by far not the cleanest. But to be honest the whole js here is kind of a mess...

Please test and review.

* Get the path in the documents app
* A new share.js to make it work with the OCS Share API

Thanks to @oparoz for the hard work on share.js
@rullzer rullzer added this to the 9.0.1-current-maintenance milestone Mar 16, 2016
@PVince81
Copy link
Contributor

Not sure what this fixes, but it doesn't work for local shares:

  1. Create a new document in the documents app
  2. Click "Share"
  3. Type in "user1" and share with "user1"

Two problems:

  • a link share is already precreated
  • sharing with a user gives 404

documents-share

@PVince81
Copy link
Contributor

in case it matters, the browser's current URL is "http://localhost/owncloud/index.php/apps/documents/index#557"

@rullzer
Copy link
Author

rullzer commented Mar 22, 2016

mm works here... I'll try to reproduce your bug...

@briskspirit
Copy link

Same 404 error here with same Request URL.

@ghost ghost modified the milestones: 9.0.2-current-maintenance, 9.0.1 Apr 8, 2016
@reuterbal
Copy link

Not seeing any 404 errors with this URL or when trying to share inside the documents app.
However, sharing bug still persists. Call to
/ocs/v2.php/apps/files_sharing/api/v1/shares?format=json&path=7563&shared_with_me=true
seems to work fine (200) but console shows "Type Error: result.ocs is undefined" with the following backtrace:

Share._loadShares/<()
 share.js:636
x.Callbacks/c()
 jquery.min.js:4
x.Callbacks/p.add()
 jquery.min.js:4
Share._loadShares()
 share.js:627
Share.showDropDown()
 share.js:144
.showDropdown()
 ocShare.js:29
.cache["dojo/_base/lang"]/</g.hitch/<()
 jquery.min.js:42

@PVince81 PVince81 modified the milestones: 9.0.3-next-maintenance, 9.0.2-current-maintenance Apr 19, 2016
@PVince81 PVince81 modified the milestones: 9.0.4-next-maintenance, 9.0.3-current-maintenance Jun 17, 2016
@PVince81 PVince81 modified the milestones: 9.0.5, 9.0.4 Jul 18, 2016
@PVince81 PVince81 modified the milestones: 9.0.6, 9.0.5 Sep 21, 2016
@PVince81 PVince81 modified the milestones: 9.0.7, 9.0.6 Oct 20, 2016
@PVince81 PVince81 removed this from the 9.0.7 milestone Nov 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants