Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Add tests for zero-byte file upload on public share #10697

Merged
merged 5 commits into from
Jan 2, 2025
Merged

[tests-only][full-ci] Add tests for zero-byte file upload on public share #10697

merged 5 commits into from
Jan 2, 2025

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Dec 2, 2024 •
edited
Loading

Description

In this PR, there is an added bug coverage test. Following scenarios are added for upload via webdav api:

Scenario: public uploads a zero byte file to a public share folder
Scenario: public uploads a zero byte file to a public share folder inside project space
Scenario: public uploads a zero byte file to a public share project space

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • CI
  • locally
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Dec 2, 2024
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 2 times, most recently from ac4f914 to 84fc885 Compare December 9, 2024 09:33
@nabim777 nabim777 changed the title [tests-only] Add tests for zero-byte file upload on spaces [tests-only] [full-ci] Add tests for zero-byte file upload on spaces Dec 9, 2024
@nabim777 nabim777 changed the title [tests-only] [full-ci] Add tests for zero-byte file upload on spaces [tests-only][full-ci] Add tests for zero-byte file upload on spaces Dec 9, 2024
@nabim777 nabim777 marked this pull request as ready for review December 9, 2024 10:41
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 3 times, most recently from 94e35c9 to c496f3e Compare December 10, 2024 04:02
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 2 times, most recently from e4591b7 to 2a5d18e Compare December 10, 2024 08:18
@nabim777 nabim777 requested a review from S-Panta December 10, 2024 08:19
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 2a5d18e to 3b4a444 Compare December 10, 2024 08:22
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 3b4a444 to fc2784b Compare December 10, 2024 09:37
@nabim777 nabim777 enabled auto-merge December 10, 2024 09:53
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch 2 times, most recently from 0d84e32 to ab70496 Compare December 13, 2024 10:14
@Salipa-Gurung Salipa-Gurung changed the title [tests-only][full-ci] Add tests for zero-byte file upload on spaces [tests-only][full-ci] Add tests for zero-byte file upload on public share Dec 16, 2024
@nabim777 nabim777 requested a review from phil-davis December 17, 2024 05:42
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from ab70496 to 8d46b46 Compare December 18, 2024 03:35
@nabim777 nabim777 requested a review from S-Panta December 18, 2024 03:36
@anon-pradip
Copy link
Contributor

Seems okay for me 👍

@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 4007c06 to 16a7a6e Compare December 30, 2024 11:23
@nabim777 nabim777 requested a review from saw-jan December 30, 2024 11:24
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 16a7a6e to 3ef2ca3 Compare January 2, 2025 03:56
@nabim777 nabim777 requested a review from saw-jan January 2, 2025 03:56
@nabim777 nabim777 force-pushed the tests/zero-byte-upload branch from 3ef2ca3 to 0a7977c Compare January 2, 2025 03:59
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@saw-jan saw-jan merged commit d32d3f1 into master Jan 2, 2025
4 checks passed
@saw-jan saw-jan deleted the tests/zero-byte-upload branch January 2, 2025 06:03
ownclouders pushed a commit that referenced this pull request Jan 2, 2025
@saw-jan
Merge pull request #10697 from owncloud/tests/zero-byte-upload
1b3f6b7 
[tests-only][full-ci] Add tests for zero-byte file upload on public share
ownclouders pushed a commit that referenced this pull request Jan 3, 2025
@saw-jan
Merge pull request #10697 from owncloud/tests/zero-byte-upload
68d8670 
[tests-only][full-ci] Add tests for zero-byte file upload on public share
ownclouders pushed a commit that referenced this pull request Jan 3, 2025
@saw-jan
Merge pull request #10697 from owncloud/tests/zero-byte-upload
aa70140 
[tests-only][full-ci] Add tests for zero-byte file upload on public share
ownclouders pushed a commit that referenced this pull request Jan 4, 2025
@saw-jan
Merge pull request #10697 from owncloud/tests/zero-byte-upload
1086c78 
[tests-only][full-ci] Add tests for zero-byte file upload on public share
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@SagarGi SagarGi Awaiting requested review from SagarGi

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@phil-davis phil-davis Awaiting requested review from phil-davis

@S-Panta S-Panta Awaiting requested review from S-Panta

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nabim777 @anon-pradip @saw-jan @S-Panta @PrajwolAmatya @nirajacharya2