Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] shift existing settings api test scenarios to apiSettings test suite #10841

Merged
merged 1 commit into from
Jan 15, 2025
Merged

[tests-only][full-ci] shift existing settings api test scenarios to apiSettings test suite #10841

merged 1 commit into from
Jan 15, 2025

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jan 9, 2025 •
edited
Loading

Description

This PR

  • Shifts already existing settings API test scenarios into apiSettings test suite.
  • Removes the following scenarios
Scenario Outline: get assigned role of a user via setting api
Scenario Outline: only admin user can see assignments list
Scenario Outline: only admin user can see all existing roles

as they are covered in

Scenario Outline: user lists assignments
Scenario Outline: user lists existing roles

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Jan 9, 2025
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review January 9, 2025 11:29
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from 1f6da6a to 7d4b953 Compare January 10, 2025 04:10
saw-jan
saw-jan requested changes Jan 10, 2025
View reviewed changes
tests/acceptance/features/apiAccountsHashDifficulty/assignRole.feature
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this feature file but change tests to use graph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This suite is a special one.

@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from 7d4b953 to 6b3711c Compare January 13, 2025 07:02
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch 2 times, most recently from b078841 to 69895b5 Compare January 14, 2025 04:07
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch 2 times, most recently from 0c5a30e to dfec9b0 Compare January 15, 2025 06:36
@prashant-gurung899 prashant-gurung899 force-pushed the test/shift-settings-scenarios branch from dfec9b0 to 5744b6f Compare January 15, 2025 07:17
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@saw-jan saw-jan merged commit 44c2a41 into master Jan 15, 2025
4 checks passed
@saw-jan saw-jan deleted the test/shift-settings-scenarios branch January 15, 2025 08:23
ownclouders pushed a commit that referenced this pull request Jan 15, 2025
@saw-jan
Merge pull request #10841 from owncloud/test/shift-settings-scenarios
274b017 
[tests-only][full-ci] shift existing settings api test scenarios to `apiSettings` test suite
@prashant-gurung899 prashant-gurung899 mentioned this pull request Jan 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prashant-gurung899 @saw-jan