Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] add test to disable in-app notification for Share Removed event #10893

Merged
merged 1 commit into from
Jan 22, 2025
Merged

[full-ci][tests-only] add test to disable in-app notification for Share Removed event #10893

merged 1 commit into from
Jan 22, 2025

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jan 20, 2025 •
edited
Loading

Description

This PR adds test to disable in-app notification for Share Removed event.

Scenario: disable in-app notification for Share Removed event

For Share Removed event, only in-app notifications can be enabled/disabled.

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@prashant-gurung899 prashant-gurung899 self-assigned this Jan 20, 2025
@prashant-gurung899 prashant-gurung899 mentioned this pull request Jan 20, 2025
Open
17 tasks
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch 4 times, most recently from 3797795 to 8e475d8 Compare January 21, 2025 04:25
@prashant-gurung899 prashant-gurung899 marked this pull request as ready for review January 21, 2025 04:56
amrita-shrestha
amrita-shrestha reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update description with information why mail notification scenario is not included

tests/acceptance/features/apiSettings/notificationSetting.feature Show resolved Hide resolved
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from 8e475d8 to 45a4aab Compare January 21, 2025 07:19
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from 45a4aab to 27ffc8a Compare January 21, 2025 08:51
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from 27ffc8a to 367289e Compare January 21, 2025 09:10
amrita-shrestha
amrita-shrestha reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm me but did you add coverage for resource inside project ? If not better if added in this PR

@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from 367289e to d15f88c Compare January 21, 2025 10:47
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from d15f88c to 2f3ff02 Compare January 21, 2025 10:58
@prashant-gurung899 prashant-gurung899 force-pushed the test/share-received-notifications branch from 2f3ff02 to 1cc23a9 Compare January 21, 2025 11:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

amrita-shrestha
amrita-shrestha approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nabim777
nabim777 reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@prashant-gurung899 prashant-gurung899 merged commit ecf1a1b into master Jan 22, 2025
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the test/share-received-notifications branch January 22, 2025 05:59
ownclouders pushed a commit that referenced this pull request Jan 22, 2025
@prashant-gurung899
Merge pull request #10893 from owncloud/test/share-received-notificat…
c091c8c 
…ions

[full-ci][tests-only] add test to disable in-app notification for `Share Removed` event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabim777 nabim777 nabim777 left review comments

@amrita-shrestha amrita-shrestha amrita-shrestha approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@prashant-gurung899 prashant-gurung899

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prashant-gurung899 @saw-jan @amrita-shrestha @nabim777