Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] refactor scenario to disable mail notification for Share removed event #10925

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Jan 24, 2025

Description

This PR refactors the following scenarios to include disabling mail notifications for Share removed event.
This is a recently added new feature : #10904

Scenario: disable in-app notification for Share Removed event
Scenario: disable in-app notification for Share Removed event (Project space)

Refactored into:

Scenario: disable mail and in-app notification for Share Removed event
Scenario: disable mail and in-app notification for Share Removed event (Project space)

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prashant-gurung899 prashant-gurung899 merged commit a8137a4 into master Jan 24, 2025
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the test/share-removed-email branch January 24, 2025 11:32
ownclouders pushed a commit that referenced this pull request Jan 24, 2025
[tests-only][full-ci] refactor scenario to disable mail notification for `Share removed` event
ownclouders pushed a commit that referenced this pull request Jan 25, 2025
[tests-only][full-ci] refactor scenario to disable mail notification for `Share removed` event
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants