Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Add tests for share expiry #10935

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amrita-shrestha
Copy link
Contributor

@amrita-shrestha amrita-shrestha commented Jan 28, 2025

Description

This PR add tests for checking in-app and mail notification alert for resource share expiry of personal .

  • Project drive have bug i.e generate 2 notification for share expire event
  • Fixed retry on filterResponseAccordingToNotificationSubject()
  • Fixed cleanup in after hook

I tried two approach

  • one adding new step
  • another modifying update share step need refactoring on step
    And the fields of the last response to user "Alice" should include and strict expiration date is not possible in simple way

Flakiness Alert

  • Don't not use list all notification step in this scenario, it will gives flakiness

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Jan 28, 2025
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch 3 times, most recently from ffa135a to 0aa56bb Compare January 28, 2025 10:31
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch 3 times, most recently from add3c55 to c1778d1 Compare January 28, 2025 11:20
@amrita-shrestha amrita-shrestha changed the title [tests-only][full-ci] Add tests for share exipry [tests-only][full-ci] Add tests for share expiry Jan 29, 2025
@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented Feb 4, 2025

blocked until this PR get merged #10955

@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch 5 times, most recently from 173fdf5 to 7a4f94b Compare February 4, 2025 07:49
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch 4 times, most recently from db49698 to 8537813 Compare February 4, 2025 09:55
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch from 8537813 to 40e57b6 Compare February 5, 2025 08:34
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch 2 times, most recently from 4970960 to 64670d2 Compare February 6, 2025 05:24
@amrita-shrestha amrita-shrestha force-pushed the add-test-for-share-expiry-notification branch from 64670d2 to c658fc3 Compare February 6, 2025 06:44
Copy link

sonarqubecloud bot commented Feb 6, 2025

@amrita-shrestha
Copy link
Contributor Author

blocked until this PR get merged #10972

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants