Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release User LDAP 0.15.4 #605

Closed
36 of 41 tasks
phil-davis opened this issue Dec 9, 2020 · 15 comments · Fixed by #658
Closed
36 of 41 tasks

Release User LDAP 0.15.4 #605

phil-davis opened this issue Dec 9, 2020 · 15 comments · Fixed by #658
Assignees
Milestone

Comments

@phil-davis
Copy link
Contributor

phil-davis commented Dec 9, 2020

Reason

  • for PR Apply changes from master build process docs#599 "Fixed read LDAP attribute value 0 returned as null"
  • ... and whatever else has been merged recently:
    • Security: filter special characters from password field #636
    • LDAP multiple base dns break pagination #307
    • Add warning for disabling email login regarding strict login check #581 (Requires 10.5.0)
    • Facelift #597

Product approval

  • Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
  • Ping pmaier to check info.xml description and screenshot
  • Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

  • Create QA Milestone and set the description to $version
  • Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
  • Create release branch with the format "release-$version"
  • Create "$version Testplan" -> [QA] 0.15.3 Testplan #638
  • copy new/reopened issues from the previous release ticket as 'Issues to review' below.
  • check if Non-normal Release Process applies, and adapt this checklist.

Documentation

  • Changes in the docs needed? If so create issue in owncloud/docs. -> ttps://github.com/owncloud/docs/issues/3684

Marketing

Build

All actions to be done on the release branch from here:

  • Bump version in info.xml (no version suffix)
  • Check php version dependency in info.xml
  • Check minimum ownCloud version dependency in info.xml
  • Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

  • Ping product owner to create github tag for v${version}-rc1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
  • Build and sign RC tarball from github tag v${version}-rc1 (see handbook for how to build)
  • Upload as Github release using changelog entries
  • Manual explorative testing:
    • If this is an enterprise app: Enabling the app must start the grace period
    • If this is the initial release of an app: Check that the minimum version constraint resolves correctly
    • Changelog testing
    • Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch

Final

  • Check that no documentation issues are pending
  • Rename last RC tarball to final
  • Create github tag for final v${version} on release branch
  • Upload as Github release using changelog entries
  • Ping #marketing channel to coordinate publishing

Publishing

  • Upload tarball to marketplace (see handbook in confluence for details)
  • Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
  • Send mail to release-coordination with link to this ticket and to the changelog
  • Copy email to rocket chat #updates channel

Post-release

@micbar micbar changed the title Release 0.15.3 Release User LDAP 0.15.3 Jan 7, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Apr 15, 2021

use openldap docker. https://github.com/owncloud-docker/compose-playground/tree/master/compose#compose-playground
Suggested example:

docker-compose \
    -f owncloud-base.yml \
    -f owncloud-official.yml \
    -f cache/redis.yml \
    -f database/mariadb.yml \
    -f ldap/openldap.yml \
    -f ldap/openldap-mount-ldif.yml \
    up

@C0rby
Copy link

C0rby commented May 3, 2021

https://gitea.owncloud.services/security/user_ldap/pulls/1 should be included into the next release

@jnweiger
Copy link
Contributor

https://gitea.owncloud.services/security/user_ldap/pulls/1 should be included into the next release
Did you see the comment from @butonic about the regexp?

We'll push forward with the 0.15.3 release in the next week. I'd love to see a PR for this!

@jnweiger
Copy link
Contributor

@phil-davis the last 4 nightly builds for user_ldap failed. Is that random glitches, or something that needs fixing before we roll a release?

@phil-davis
Copy link
Contributor Author

@phil-davis the last 4 nightly builds for user_ldap failed. Is that random glitches, or something that needs fixing before we roll a release?

That was due to some core changes to creating tags and related acceptance test changes that are not compatible with latest core 10.7.0. Fixed by owncloud/core#38784 - I expect to see green CI this morning.

@C0rby
Copy link

C0rby commented May 31, 2021

https://gitea.owncloud.services/security/user_ldap/pulls/1 should be included into the next release
Did you see the comment from @butonic about the regexp?

We'll push forward with the 0.15.3 release in the next week. I'd love to see a PR for this!

I opened one here: #636

@C0rby
Copy link

C0rby commented May 31, 2021

If it needs to go into a special branch I can redirect the PR.

@phil-davis
Copy link
Contributor Author

I expect to see green CI this morning.

@jnweiger CI was green for user_ldap last night - all good.

@micbar
Copy link
Contributor

micbar commented Jun 10, 2021

Ready to go into RC.

@jnweiger
Copy link
Contributor

jnweiger commented Jun 14, 2021

Release branch created. Tagged RC1. Prerelease at github https://github.com/owncloud/user_ldap/releases/tag/v0.15.3-rc1

@jnweiger jnweiger added this to the QA milestone Jun 14, 2021
@jnweiger jnweiger pinned this issue Jun 14, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Jul 7, 2021

Changelog Testing

  • Quota '0 MB' and '0' are both correctly synced from ldap into owncloud.
  • 1100 users were synced from one base dn, while another base dn only had 4 users.
  • warning about disabled email login regarding strict login check was seen.
  • facelift was fixed in several places before passing

Changelog testing passed. Manual regression testplan also passed (with (IMHO) non-blocker defects).
-> Ready to release.

@jnweiger jnweiger unpinned this issue Jul 7, 2021
@jnweiger jnweiger changed the title Release User LDAP 0.15.3 Release User LDAP 0.15.4 Jul 7, 2021
@jnweiger
Copy link
Contributor

jnweiger commented Jul 7, 2021

Late fix appears after 0.15.3 was pushed to marketplace: #660

  • delete 0.15.3 from the portals
  • unpublish 0.15.3 from marketplace
  • tag as v0.15.4-RC1
  • test with oauth2 [QA] Frontend breaks with other auser auth apps #659
  • add oauth2 to the testplan
  • Upload tarball to marketplace (see handbook in confluence for details)
  • Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
  • update last post to rocket chat #updates channel to say v0.15.4 instead of v0.15.3

@jnweiger
Copy link
Contributor

@jnweiger
Copy link
Contributor

Tests with core 10.8.0-rc1 passed. See https://github.com/owncloud/enterprise/issues/4508#issuecomment-883398925

@jnweiger jnweiger modified the milestones: 0.15.3, 0.15.4 Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants