Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] tab break into new line hides content #656

Closed
mmattel opened this issue Jul 7, 2021 · 6 comments
Closed

[QA] tab break into new line hides content #656

mmattel opened this issue Jul 7, 2021 · 6 comments
Assignees

Comments

@mmattel
Copy link
Contributor

mmattel commented Jul 7, 2021

Opera, Chrome, FF

If force reloading the screen, this looks like that πŸ’₯

image

But if resizing the screen it changes to the correct view βœ…

image

@jnweiger needs to be added to the defect list in #605

@janackermann @hurradieweltgehtunter mind to take a look if you can fix this?

@hurradieweltgehtunter hurradieweltgehtunter self-assigned this Jul 7, 2021
hurradieweltgehtunter added a commit that referenced this issue Jul 7, 2021
@mmattel
Copy link
Contributor Author

mmattel commented Jul 7, 2021

@hurradieweltgehtunter thanks a lot

@mmattel
Copy link
Contributor Author

mmattel commented Jul 7, 2021

@hurradieweltgehtunter has the commit be merged? I cant find it or I am just blind...
If merged, we can close the issue.

@mmattel mmattel closed this as completed Jul 7, 2021
@mmattel mmattel reopened this Jul 7, 2021
@AlexAndBear
Copy link

@mmattel the commits are in the release branch: https://github.com/owncloud/user_ldap/commits/release-0.15.3
they will be back-merged into the master branch after release

@jnweiger
Copy link
Contributor

jnweiger commented Jul 7, 2021

Tested in 0.15.4-rc1:

  • The tabs now scroll with the contents.
    image

  • The "Configuration OK" message is see twice, top and bottom.
    image

  • when there is little horizontal space, the "Configuration OK" jump into the heading, and looses the server information:
    image

@hurradieweltgehtunter That seems to revert parts if the initial facelift. (e.g. Fixed top bar)

@hurradieweltgehtunter
Copy link
Contributor

Yes it reverts parts of it but this is intended/forced.
I fixed the third issue you mentioned in release-0.15.3

@jnweiger
Copy link
Contributor

Retested in 0.15.4-RC2

  • Can no longer reproduce Martin's origina lissue here. No overlaps. The contents properly jumps down, when the tabs wrap.
  • the tabs row scrolls up with the content
  • proper whitespace aorond the green ball.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants