Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding dicom-viewer.yml #67

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adding dicom-viewer.yml #67

wants to merge 3 commits into from

Conversation

koebel
Copy link
Collaborator

@koebel koebel commented Nov 20, 2024

Description

enables admins to add DICOM Viewer with only a few lines in .env to the oCIS deployment example

Related Issue

Motivation and Context

make it as easy as possible for admins to add the extension to their installation

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@koebel koebel mentioned this pull request Nov 20, 2024
7 tasks
@koebel koebel changed the title adding apps.yaml adding dicom-viewer.yml Nov 21, 2024
@koebel koebel self-assigned this Nov 21, 2024
koebel added a commit that referenced this pull request Nov 21, 2024
file still needs to be correctly configured and corresponding branch (#67) needs to be merged
@koebel koebel marked this pull request as ready for review November 22, 2024 08:45
Copy link

sonarcloud bot commented Nov 22, 2024

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can I use this? is there any docs?

Copy link
Collaborator Author

@koebel koebel Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #64, section "adding Dicom Viewer to ocis Deployment Example"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it.

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

condition: service_completed_successfully

dicomviewer-init:
image: owncloud/web-app-dicom-viewer/dicom-viewer-1.0.0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still have to create the corresponding docker image!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants