-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Cache playwright chromium #11958
Conversation
fa7388c
to
3bb587f
Compare
72181e5
to
76178bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using browsers
instead of chromium
thank you Amrita, that is great job 👍
|
@ScharfViktor, I believe the cache lifespan is 30 days. check_chromium_cache method verifies the existence of the Chromium cache during each build, based on the Playwright version specified in the package.json file. If the cache is missing, the installChromium and cacheChromium steps are triggered, aligned with the specified Playwright version. If the bot updates the Playwright version, a new Chromium version will be installed and cached, while the old Chromium cache will remain until its lifespan expires. It seems adding a script to remove the old cache when a new one is uploaded could interfere with other running builds, so that idea has been dropped to avoid potential disruptions. As shown in the image above, 1.49.0 represents the Playwright version. Currently, the Chromium cached tar file is stored in a directory named after the Playwright version. |
ac303fd
to
6c8ee46
Compare
6c8ee46
to
4583317
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* cache chronium * cache * restore-cache * unskip pipelines * zip chromium cache * rename and remove old cache when new version cache uploaded * don't remove old browser cache
Description
This PR
PLUGINS_S3 = "plugins/s3:1.5"
versionNote
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: