[WIP] Closed group rebuild #730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the new properties to the ClosedGroup type Updated the thread settings UI and actions to match the updated group options Updated the thread notification settings UI
# Conflicts: # Session.xcodeproj/project.pbxproj
…ixes Attempting to clean up the SessionCell.Info interface a bit more now things are getting more complex Refactored the BlockedContactsViewController to use the SessionTableViewController Updated the SessionTableViewController to support PagedDataObservers, have an emptyStateLabel and have a footerButton (with fadeView) Updated the SessionTableViewController to generate it's StagedChangeset within the viewModel Renamed a couple of variables to genericise them Fixed a couple of odd bugs related to the iOS 16 changes to layoutMargins Removed some redundant function overrides
Added the "search" capability to the group member/invite/admin screens Cleaned up some editing state management for the SessionCell
Added empty states to the group member list screen Removed the 'leave group' option if the user is the only admin Removed some unused assets
…-rebuild # Conflicts: # Session/Settings/BlockedContactsViewModel.swift
Removed the old 'GroupContext' value from the protobuf Updated the logic so the ClosedGroup 'isApproved' flag correctly segments threads as message requests Fixed a bug where some messages on the screen wouldn't get marked as read when opening a conversation
Moved the request batching types into the SessionUtilitiesKit in advance of adding batched requests to the SessionSnodeKit Fixed a bug where copying the open group URL wasn't generating a correct URL Fixed a bug where declining a message request would pop to the home screen (instead of the message requests screen) Cleaned up the SessionThreadViewModel closed group avatar retrieval queries a little
Removed the old hark fork closed group polling logic Started updating the snode requests to use codable types Started cleaning up some of the poller logic
Continued making the SnodeAPI requests more like the OpenGroupAPI ones
Cleaned up the batching types (removed some redundant types)
Consolidated the Poller and ClosedGroupPoller logic ('Poller' is now the super class and there is a 'CurrentUserPoller')
Removed some unused code Fixed an issue where editing the users profile name wasn't working
…d properly to the nav
Added @admin and @everyone functionality to closed groups Added the "auto download attachments" functionality Updated the conversation cells to identify closed/open groups using an icon Fixed a bug where mention fallback avatars in open groups weren't correctly showing initials
Fixed a bug where the 'Note to Self' conversation might not appear correctly in Global Search for newly created accounts Fixed a bug where the seed reminder view was truncating the 'Continue' button on some devices
|
Closing this as it's now been superseded by #894 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.