update: Update to revamped c binding (#147)

* update mlx-c

* removed shim

* partial updates to new c api

* update fft

* update dtype and device

* updated indexing

* updated index and fft ops to take impl AsRef<Array>

* use custom Result type alias

* avoid conflict

* updated more mods

* update logical

* updated optmizers

* updated compile

* updated transforms

* updated shapes

* updated quantization

* added more linalg fns

* updated io

* need clone

* impl Clone using mlx_array_set

* add comments about Vec<&Array>

* clippy and fmt

* revert back to cloning

* revert to perform type casting in item

* default all fft/ifft on cpu for now

* pass all tests

* try fix CI problem

* Revert "try fix CI problem"

This reverts commit 3c8ca26.

* Use newer Xcode

* free new mlx_array if cloning fails

* added guard

* impl guard and guarded for vec pairs

* make most ops return result regardless of underlying c++ impl

* renamed try_op to try_from_op

* update index to use guarded

* update to Guarded

* update to Guarded op

* update remaning ops to use Guarded op

* added test_clip_grad_norm

* clippy and fmt

* fix doctest

* update mlx-c to tags/v0.1.0

* remove device = "cpu"

* remove affine_quantize which was removed from python and swift as well

* change newtype wrapper to type alias

* fix latest clippy warnings

* cargo fmt

* remove unused static

* update mlx-sys crate version to match mlx-c

* re-export ModuleParameters macro

* changing test_celu to follow the python version

* try using gh hosted mac runners

* try setting CMAKE_OSX_DEPLOYMENT_TARGET

* try setting runner to macos-15

* try setting xcode version to 15.2

* try setting xcode version to 16.1

* try xcode 16.1 on macos-14

* try macos-14 and xcode 16.0

* need macos-15

* try blaze/macos-15 runners

---------

Co-authored-by: David Chavez <[email protected]>

.github/workflows/validate.yml

@@ -5,17 +5,20 @@ on:
       - main
   pull_request:
     types: [opened, synchronize]
+
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 jobs:
   rustfmt-check:
-    runs-on: blaze/macos-14
+    runs-on: blaze/macos-15
     steps:
       - name: Checkout
         uses: actions/checkout@v4
         with:
           submodules: true
+      - name: Setup Xcode
+        run: sudo xcodes select 16.0
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
@@ -26,7 +29,7 @@ jobs:
         run: cargo clippy -- -D warnings
 
   tests:
-    runs-on: blaze/macos-14
+    runs-on: blaze/macos-15
     strategy:
       matrix:
         rust: [ stable, 1.75.0 ]
@@ -40,6 +43,8 @@ jobs:
         uses: actions/checkout@v4
         with:
           submodules: true
+      - name: Setup Xcode
+        run: sudo xcodes select 16.0
       - name: Install Rust
         uses: actions-rust-lang/setup-rust-toolchain@v1
         with:
@@ -51,4 +56,4 @@ jobs:
         with:
           key: ${{ runner.os }}-${{ matrix.cache }}-${{ matrix.backend }}-${{ hashFiles('**/Cargo.toml') }}
       - name: Run tests
-        run: cargo test --all -- --test-threads=1 # MLX is not thread safe
+        run: cargo test --all -- --test-threads=1 # MLX is not thread safe

Cargo.toml

@@ -20,7 +20,7 @@ resolver = "2"
 
 [workspace.dependencies]
 # workspace local dependencies
-mlx-sys = { version = "0.0.10", path = "mlx-sys" }
+mlx-sys = { version = "0.1.0", path = "mlx-sys" }
 mlx-macros = { version = "0.1.0", path = "mlx-macros" }
 mlx-internal-macros = { version = "0.1.0", path = "mlx-internal-macros" }
 mlx-rs = { version = "0.14.0", path = "mlx-rs" }

examples/mnist/src/mlp.rs

@@ -7,7 +7,7 @@ pub struct Mlp {
     pub layers: Sequential,
 }
 
-impl<'a> Module<&'a Array> for Mlp {
+impl Module<&Array> for Mlp {
     type Error = Exception;
     type Output = Array;
 

mlx-internal-macros/src/shared.rs

@@ -34,7 +34,7 @@ pub(crate) struct BuilderStructAnalyzer<'a> {
     pub err: Option<&'a syn::Path>,
 }
 
-impl<'a> BuilderStructAnalyzer<'a> {
+impl BuilderStructAnalyzer<'_> {
     pub fn generate_builder_struct(&self) -> proc_macro2::TokenStream {
         let struct_ident = self.struct_ident;
         let builder_ident = self.builder_struct_ident;