Add instance to anti-affinity group in create form #2788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjaminleonard
commented
Apr 8, 2025
| @@ -169,6 +173,9 @@ export async function clientLoader({ params }: LoaderFunctionArgs) { | |||
| apiQueryClient.prefetchQuery('currentUserSshKeyList', {}), | |||
| apiQueryClient.prefetchQuery('projectIpPoolList', { query: { limit: ALL_ISH } }), | |||
| apiQueryClient.prefetchQuery('floatingIpList', { query: { project, limit: ALL_ISH } }), | |||
| apiQueryClient.prefetchQuery('antiAffinityGroupList', { | |||
There was a problem hiding this comment.
Number of groups is likely to be low. Curious if there is a threshold where its better to move this stuff after the page is loaded.
|
What if the combobox was inline instead of in a modal? |
|
Worth a try, but we would need to change the floating IPs one also |
|
There's a few other things on that, e.g. do we do that for attach disks also? Do we stack the listbox and button (like firewall rules)? For now I'd say we defer that, since I've been trying to figure out a minitable and integrated input pattern for the webhooks work and also solve confusion around fields not being added in the firewall rules modal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration might not be the best place in the advanced accordion to put it, but not sure if it justifies its own section. Added to the
instanceCreatehandler and a e2e test.