Better error handling when tracking zone datalinks #7991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
force-pushed
the
lessy-the-blocky
branch
from
7d1a7bb to
fd5ff5b
Compare
- Make operations for tracking / untracking datalinks in zones return actual error information, rather than a boolean. - Use `try_send()` internally when sending messages to the actual metrics task, to avoid blocking indefinitely if that task is corked. This helps ensure we don't block things like the instance lifecycle simply because we couldn't track the Propolis zone's datalinks -- we'd rather the instance boot without those in that case. - Fixes #7869
bnaecker
force-pushed
the
lessy-the-blocky
branch
from
fd5ff5b to
88cd3ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try_send()internally when sending messages to the actual metrics task, to avoid blocking indefinitely if that task is corked. This helps ensure we don't block things like the instance lifecycle simply because we couldn't track the Propolis zone's datalinks -- we'd rather the instance boot without those in that case.