-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve SARIF errors and warnings correctly #4837
Draft
bdovaz
wants to merge
17
commits into
main
Choose a base branch
from
retrieve-sarif-results
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
---|---|---|---|---|---|---|
✅ API | spectral | 1 | 0 | 0 | 1.57s | |
bash-exec | 6 | 1 | 0 | 0.03s | ||
✅ BASH | shellcheck | 6 | 0 | 0 | 0.24s | |
✅ BASH | shfmt | 6 | 0 | 0 | 0 | 0.95s |
✅ COPYPASTE | jscpd | yes | no | no | 2.75s | |
✅ DOCKERFILE | hadolint | 129 | 0 | 0 | 31.29s | |
✅ JSON | jsonlint | 20 | 0 | 0 | 0.19s | |
✅ JSON | v8r | 22 | 0 | 0 | 15.35s | |
markdownlint | 267 | 0 | 302 | 0 | 21.39s | |
✅ MARKDOWN | markdown-table-formatter | 267 | 0 | 0 | 0 | 168.16s |
bandit | 215 | 66 | 0 | 2.81s | ||
✅ PYTHON | black | 215 | 0 | 0 | 0 | 5.11s |
✅ PYTHON | flake8 | 215 | 0 | 0 | 2.14s | |
✅ PYTHON | isort | 215 | 0 | 0 | 0 | 1.48s |
✅ PYTHON | mypy | 215 | 0 | 0 | 12.07s | |
✅ PYTHON | pylint | 215 | 0 | 0 | 33.67s | |
✅ PYTHON | ruff | 215 | 0 | 0 | 0 | 0.68s |
✅ REPOSITORY | checkov | yes | no | no | 38.12s | |
✅ REPOSITORY | git_diff | yes | no | no | 0.74s | |
grype | yes | 28 | no | 25.87s | ||
✅ REPOSITORY | secretlint | yes | no | no | 8.66s | |
✅ REPOSITORY | trivy | yes | no | no | 15.28s | |
✅ REPOSITORY | trivy-sbom | yes | no | no | 0.58s | |
trufflehog | yes | 1 | no | 55.25s | ||
✅ SPELL | cspell | 718 | 0 | 0 | 12.31s | |
lychee | 349 | 33 | 0 | 7.47s | ||
✅ XML | xmllint | 3 | 0 | 0 | 0 | 0.93s |
✅ YAML | prettier | 160 | 0 | 0 | 0 | 4.13s |
✅ YAML | v8r | 103 | 0 | 0 | 31.72s | |
✅ YAML | yamllint | 161 | 0 | 0 | 3.26s |
See detailed report in MegaLinter reports
3 tasks
This PR is blocked because of the issues / PRs I mention. I have managed to merge in grype the PR and the pmd one created by someone else is still in progress, with that one I think there would be no more blockages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @nvuillam's request I have:
sarif
tocli_lint_errors_count
in json scheme (was implemented in code but not added to schema)sarif
tocli_lint_warnings_count
in json schemeThere are linters that do not fill out the SARIF
level
field:llaville/sarif-php-converters#1 (Fixed!)
pmd/pmd#5573
anchore/grype#2511 (Fixed but not released yet)
In these cases if they do not fill in the “level” field as I have put in the first message, according to the specification the default value is “warning” so it will be reported as such.
There are other cases Python Bandit that fills levels that we do not show in the reporters like “note” level, in this case I make it to be interpreted as warning that is the closest one.
That is, before this PR everything was interpreted as error, now: