Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gitpod #866

Closed
wants to merge 1 commit into from

Conversation

ajhalili2006
Copy link

@ajhalili2006 ajhalili2006 commented Oct 18, 2021

Proposed Changes

  1. Adds .gitpod.yml to automatically configure Git to set core.autocrlf to true and installs extensions from Open VSX that are recommended by the project.
  2. Adds a Python script for synchronization of .vscode/extensions#recommendations to .gitpod.yml#vscode.extensions

Roadblockers in adding Gitpod support

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ajhalili2006
Copy link
Author

For the documentation stuff, maybe it should be on contributing docs, which I'll write soon.

@ajhalili2006
Copy link
Author

I just do a git pull upstream master --rebase to keep in sync eariler.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Nov 30, 2021
@ajhalili2006
Copy link
Author

Just rebased against the latest commits from the main branch, still working on the custom workspace Dockerfile.

@github-actions github-actions bot removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Dec 2, 2021
@ajhalili2006
Copy link
Author

Rebased again against main, with the latest commit related to ignoring some Hadolint warnings and errors, particularly pining some package versions in pip, gem, and npm, WORKDIR-related stuff and using latest tag for the custom Gitpod workspace image Dockerfile I'm still working on.

@nvuillam
Copy link
Member

nvuillam commented Dec 11, 2021

@ajhalili2006 Do you manually write the gitpod Dockerfile ?

If yes, I strongly suggest to automate it, else it will be too long to maintain (all Dockerfiles content are coming from descriptors and generated using build.py

If you want I can manage the automation later, but please at least keep the comments I use for replacements :) (#NPM__START, #NPM__END, #PIP__START, #PIP__END, etc .... :) )

Or if the images are similar, maybe you could base your dockerfile on megalinter/megalinter:beta and add what you need after ? ( like in Dockerfile-quick)

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2021

Codecov Report

Merging #866 (9186e3f) into main (3050e4c) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   87.71%   87.74%   +0.03%     
==========================================
  Files         138      138              
  Lines        3328     3328              
==========================================
+ Hits         2919     2920       +1     
+ Misses        409      408       -1     
Impacted Files Coverage Δ
megalinter/reporters/UpdatedSourcesReporter.py 89.18% <0.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3050e4c...9186e3f. Read the comment docs.

@ajhalili2006
Copy link
Author

ajhalili2006 commented Dec 11, 2021

I tried using the main Dockerfile in a test GitLab repo, and it's failed with the following error:

cannot ensure Gitpod user exists: [adduser -h /home/gitpod -s /bin/sh -D -G 33333 -u 33333 gitpod]: exit status 1: adduser: unknown group 33333

Maybe because its assume that the base image is Debian-based and reproducing some parts of gitpod/workspace-base.1

So maybe I'll rewrite the Gitpod Dockerfile to include only the required Python packages within the repo, and the rest maybe run as part of the container using the main Dockerfile.

Footnotes

  1. ref: https://github.com/gitpod-io/gitpod/issues/3356#issuecomment-963038577

Also on workspace init, it'll pull the latest builds from Docker Hub.
May expect some weird pull issues.

Signed-off-by: Andrei Jiroh Eugenio Halili <[email protected]>
@ajhalili2006
Copy link
Author

Since I force pushed stuff with lease, old commits can be found at https://github.com/ajhalili2006/mega-linter/tree/old-draft/gitpodify-repo branch.

@nvuillam
Copy link
Member

Still draft ? :)

@ajhalili2006 ajhalili2006 marked this pull request as ready for review January 13, 2022 03:59
@ajhalili2006 ajhalili2006 changed the title Draft: Add support for Gitpod Add support for Gitpod Jan 13, 2022
@ajhalili2006
Copy link
Author

Hey @nvuillam, Sorry for the long wait. I'm going to rebase the branch later to ensure its in sync with the main branch.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Feb 13, 2022
@nvuillam nvuillam removed the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Feb 13, 2022
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this pull request should stay open, please remove the O: stale 🤖 label or comment on the pull request.

@github-actions github-actions bot added the O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity label Mar 16, 2022
@github-actions github-actions bot closed this Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: stale 🤖 This issue or pull request is stale, it will be closed if there is no activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants