Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify requests ReadTimeout #53

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

TylerAldrich
Copy link

Add ability to customize requests ReadTimeout if session with timeout attribute is passed in, otherwise default to decorators value.

Allows you to pass in your own requests.Session() object with a timeout field. This allows people to have a customized ReadTimeout that is much shorter than the default 60 seconds. Useful when Firebase is having intermittent server issues, so retrys can happen at a quicker rate.

… attribute is passed in, otherwise default to decorators value
@garhiggins
Copy link

+1, was just considering writing this same pull request.

@rodrhern
Copy link

+1 for the fix
http_connection overwrites timeout, even if you provide a connection with a different timeout, you will always have 60

@b4oshany b4oshany merged commit a037582 into ozgur:master Aug 10, 2018
@TylerAldrich TylerAldrich deleted the connection_timeouts branch September 1, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants