-
Notifications
You must be signed in to change notification settings - Fork 179
[DO NOT MERGE} initial zsh support #355
base: master
Are you sure you want to change the base?
Conversation
- wget - bottom of terminal is now updated when Download is initiated, and progress is updated, but it is not cleared when download finished/canceled - ps - menus actually show up now
ls termlet is working as expected, ps termlet is now working as well. wget termlet updates the status bar when download is initiated and when progress updates, but not when download is cancelled/finished. history completion is not working at this time as well. |
another major oddity right now is that the prompt is inheriting from the shell finalterm is launched from currently and not updating properly. |
…ult setting (bash) if SHELL is not supported
Improved shell handling a bit, now attempt to consume $SHELL from environment and if supported, then use it otherwise fall back to the default value in Settings.get_default().shell_path |
|
||
if (!(shell_basename in valid_shells)){ | ||
message(_("shell defined in environment is not supported, falling back to bash")); | ||
shell = Settings.get_default().shell_path; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Settings.get_default().shell_path
returns an invalid shell, we will proceed with that invalid shell from this point anyway. Instead, this should somehow "hardcode" bash so we have a true fallback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, I'll add logic to force bash if Settings.get_default().shell_path is not a valid shell. Thinking about it, I should also test to make sure that the shell referenced by $SHELL or shell_path actually exists as well.
I'm thinking there has got to be a better way to run configure_file on multiple files with cmake, but at least for the time being I'm defaulting to brute forcing it for the Termlet processing. I realized that different platforms might have different paths for the shells, so we should at least try to detect the shell path and set the #!'s appropriately. |
I was able to fix up the issue with the wget termlet, but it introduced a crash when hitting at the prompt: haven't had a chance to see if it is related to my zsh config or if it is a general issue yet. |
actually, looking at the full output, it looks like my prompt is being interpreted by finalterm, will need to find a way to filter that out:
|
What exactly is the content of your prompt? Is it
? |
It is indeed. But this type of prompt manipulation is common with zsh. I suspect it may just be a matter of escaping the prompt text somehow, but I haven't had a chance to dig into it yet. |
zsh still does not invoke the menu, but at least now it doesn't crash on no input
and an empty command. Looks like the cursor_position is < command_start_postion (at least with my .zshrc)
Sorry fur such a newb question, but how can I pull/implement these changes? |
Like this i think |
Changes introduced:
Outstanding issues: