-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow concatenation of string literals at compile time #1299
base: main
Are you sure you want to change the base?
Conversation
Resulting PDF spec P4-16-spec.pdf. |
Signed-off-by: Vladimir Still <[email protected]>
Signed-off-by: Vladimír Štill <[email protected]>
f2e412f
to
27fef74
Compare
@jafingerhut, @jonathan-dilorenzo, @rcgoodfellow, any comments? I'd love for this one to get in before the next spec revision goes out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Just a few nits.
Signed-off-by: Vladimir Still <[email protected]>
Thanks for the comments and sorry for the delayed response. I think I've fixed all the issues now. |
@vlstill Sorry for the inconvenience, but we have, after several months of planning, transitioned the P4 language specification source from Madoko to AsciiDoc. Thus most or all of your PRs will need to be updated so that they apply to that version. Hopefully this should be fairly straightforward, e.g. by looking at examples of how things like section headings, bullet items, etc. are marked up in the latest version of the file P4-16-spec.adoc If you have questions on how to change things for AsciiDoc, feel free to ask. Note that creating a new PR with similar changes as this PR might be easier than updating this PR. |
@jafingerhut, no problem, I've refreshed the PR for the new asciidoc documentation. |
@jonathan-dilorenzo, @rcgoodfellow this was already discussed, now there is just updated wording in the new template, can we get this merged now? |
eb9119f
to
2651459
Compare
Signed-off-by: Vladimír Štill <[email protected]>
949d2ee
to
958c576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jonathan-dilorenzo TAL at this and give comments or merge. |
This gives wording to #1297, the compile-time concatenation of strings. The P4C part of this is p4lang/p4c#4856. The changes are relatively small, I hope I have not missed any more parts that mention that there are no string operations. Note that as stated here, it also allows string concatenation in
@name
,@deprecated
and@noWarn
pragmas. The last one has probably no use for it, but I think it is better to be consistent there.Resolves #1297.