Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/cache@v2, which is soon to be retired by Github actions #546

Merged

Conversation

jafingerhut
Copy link
Contributor

No description provided.

@jafingerhut
Copy link
Contributor Author

According to a log message in a failing test for this recently created PR that modifies one of the .proto files, the Github action actions/cache@v2 used by ci-build-proto.yml is soon to be retired (2025-Mar-01), and is being failed intermittently before then as a warning to repos still using it:

Error: This request has been automatically failed because it uses a deprecated version of `actions/cache: v2`. Please update your workflow to use v3/v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

@jafingerhut
Copy link
Contributor Author

@chrispsommers @smolkaj By 2025-Mar-01, Github says that our current CI build task for compiling modified .proto files will fail deterministically as it is currently written. It fails intermittently now, as a warning.

I am not certain that this PR is the best way to improve the situation, but it seems recommended by Github.

Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's have @smolkaj take a look.

Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@smolkaj smolkaj merged commit e693bb4 into p4lang:main Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants